Wasmtime GitHub notifications bot (Apr 22 2025 at 21:53): Wasmtime GitHub notifications bot (Apr 22 2025 at 21:53):pchickey opened PR #10645 from bytecodealliance:pch/wasmtime_serve_500 to bytecodealliance:main:
Without this 500 response, hyper closes the connection without sending a response. Sending a 500 is better http hygiene.
<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (Apr 22 2025 at 21:53):pchickey requested dicej for a review on PR #10645.
Wasmtime GitHub notifications bot (Apr 22 2025 at 21:53):pchickey requested wasmtime-core-reviewers for a review on PR #10645.
Wasmtime GitHub notifications bot (Apr 22 2025 at 21:54):pchickey updated PR #10645.
Wasmtime GitHub notifications bot (Apr 22 2025 at 21:54):pchickey requested wasmtime-default-reviewers for a review on PR #10645.
Wasmtime GitHub notifications bot (Apr 22 2025 at 21:56):alexcrichton submitted PR review:
Mind adding a test around here for this as well?
Also would it perhaps make sense to render the error in the response too?
Wasmtime GitHub notifications bot (Apr 22 2025 at 22:18):pchickey updated PR #10645.
Wasmtime GitHub notifications bot (Apr 22 2025 at 22:22):pchickey commented on PR #10645:
CI revealed where existing tests covered the old behavior, so I updated that, rather than adding a test.
I don't think anyone should be using wasmtime-cli as a production server, but inevitably someone will, and in that case I don't want to put the crash information in the 500 response in case it gets exposed to untrusted users.
Wasmtime GitHub notifications bot (Apr 22 2025 at 22:26):pchickey has enabled auto merge for PR #10645.
Wasmtime GitHub notifications bot (Apr 22 2025 at 22:53):pchickey merged PR #10645.
Wasmtime GitHub notifications bot (Apr 23 2025 at 08:13):bjorn3 submitted PR review.
Wasmtime GitHub notifications bot (Apr 23 2025 at 08:13):bjorn3 created PR review comment:
Shouldn't this at show a basic html page with a user visible message that an internal server error happened like Apache and Nginx do? A completely empty page is even more confusing for end users than the browser telling the user that the connection got closed.
Wasmtime GitHub notifications bot (May 28 2025 at 09:56):bjorn3 submitted PR review.
Wasmtime GitHub notifications bot (May 28 2025 at 09:56):bjorn3 created PR review comment:
Opened https://github.com/bytecodealliance/wasmtime/pull/10851
Last updated: Dec 06 2025 at 07:03 UTC