alexcrichton requested fitzgen for a review on PR #10635.
alexcrichton opened PR #10635 from alexcrichton:fix-an-example to bytecodealliance:main:
The
Config::detect_host_featureAPI is used for detecting whether the host has a feature, not whether the compilation artifacts should have it enabled. Switch to usingcranelift_flag_enableinstead.<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
alexcrichton requested wasmtime-core-reviewers for a review on PR #10635.
alexcrichton requested wasmtime-default-reviewers for a review on PR #10635.
pchickey submitted PR review.
fitzgen commented on PR #10635:
Thanks for catching this!
fitzgen submitted PR review.
fitzgen merged PR #10635.
Last updated: Dec 06 2025 at 06:05 UTC