Stream: git-wasmtime

Topic: wasmtime / PR #10621 wasmtime component: get InstancePre ...

Wasmtime GitHub notifications bot (Apr 21 2025 at 21:10):

pchickey edited PR #10621.

Wasmtime GitHub notifications bot (Apr 21 2025 at 21:15):

alexcrichton submitted PR review.

Wasmtime GitHub notifications bot (Apr 21 2025 at 21:16):

pchickey edited PR #10621:

• wasmtime::component::InstancePre gets a new field to hold an arc to the imported resources table resource_types: Arc<PrimaryMap<ResourceIndex, ResourceType>>. This information is available at the two spots where an InstancePre is constructed (one of which is new, below), so theres no additional computation required here, just a clone of the arc.
• InstancePre gets a new method instance_type(&self) -> InstanceType<'_>. The InstanceType is used for typechecking. The whole purpose of this PR is so that typechecking can occur from either an Instance or InstancePre, and without taking a borrow into a Store, for the sake of #10610.
• wasmtime::component::Instance gets a new method instance_pre<T>(&self, store: &impl AsContext<Data = T>) -> InstancePre<T>. All of the information required to construct the InstancePre is already found in the Store at the Instances's index.
  

Wasmtime GitHub notifications bot (Apr 21 2025 at 21:16):

pchickey requested wasmtime-core-reviewers for a review on PR #10621.

Wasmtime GitHub notifications bot (Apr 21 2025 at 21:16):

pchickey has marked PR #10621 as ready for review.

Wasmtime GitHub notifications bot (Apr 21 2025 at 21:16):

pchickey requested dicej for a review on PR #10621.

Wasmtime GitHub notifications bot (Apr 21 2025 at 21:16):

pchickey requested alexcrichton for a review on PR #10621.

Wasmtime GitHub notifications bot (Apr 21 2025 at 21:38):

pchickey merged PR #10621.

Last updated: Dec 06 2025 at 07:03 UTC