Wasmtime GitHub notifications bot (Apr 16 2025 at 23:13): Wasmtime GitHub notifications bot (Apr 16 2025 at 23:13):alexcrichton opened PR #10605 from alexcrichton:fix-panicking-log to bytecodealliance:main:
This test unfortunately didn't actually have any effect in CI. Locally setting
RUST_LOGand runningcargo run test filetestsshowed a panic in the s390x backend that this test was not uncovering. The reason that this test wasn't actually doing anything on CI is that it's tested adjacently with thewasmtime-clicrate. Both crates are tested with--all-featureswhich enables the CLI'sdisable-loggingfeature which meant that all logging statements, including the ones we want to test, were compiled out.This commit fixes the s390x panic and then additionally adds a special CI job (repurposing an existing one) for testing just this test in isolation.
<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (Apr 16 2025 at 23:13):alexcrichton requested abrown for a review on PR #10605.
Wasmtime GitHub notifications bot (Apr 16 2025 at 23:13):alexcrichton requested wasmtime-compiler-reviewers for a review on PR #10605.
Wasmtime GitHub notifications bot (Apr 16 2025 at 23:13):alexcrichton requested wasmtime-default-reviewers for a review on PR #10605.
Wasmtime GitHub notifications bot (Apr 17 2025 at 13:41):abrown submitted PR review.
Wasmtime GitHub notifications bot (Apr 17 2025 at 14:08):abrown merged PR #10605.
Last updated: Dec 06 2025 at 07:03 UTC