Stream: git-wasmtime

Topic: wasmtime / PR #10584 Don't discard errors in `default_val...

Wasmtime GitHub notifications bot (Apr 15 2025 at 15:03):

alexcrichton opened PR #10584 from alexcrichton:default-value-error to bytecodealliance:main:

This commit updates the default_value helpers added recently to return a Result instead of returning an Option<T> and throwing away error information. This fixes a fuzz bug showing up recently which happened because the error in question was one we've flagged to ignore, but because the error was discarded we didn't know to ignore it so it ended up causing a fuzz failure.

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Apr 15 2025 at 15:03):

alexcrichton requested fitzgen for a review on PR #10584.

Wasmtime GitHub notifications bot (Apr 15 2025 at 15:03):

alexcrichton requested wasmtime-fuzz-reviewers for a review on PR #10584.

Wasmtime GitHub notifications bot (Apr 15 2025 at 15:03):

alexcrichton requested wasmtime-core-reviewers for a review on PR #10584.

Wasmtime GitHub notifications bot (Apr 15 2025 at 15:46):

github-actions[bot] commented on PR #10584:

Subscribe to Label Action

cc @fitzgen

<details>
This issue or pull request has been labeled: "fuzzing", "wasmtime:api"

Thus the following users have been cc'd because of the following labels:

• fitzgen: fuzzing

To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.

Learn more.
</details>

Wasmtime GitHub notifications bot (Apr 15 2025 at 15:57):

pchickey submitted PR review.

Wasmtime GitHub notifications bot (Apr 15 2025 at 16:29):

alexcrichton merged PR #10584.

Last updated: Dec 06 2025 at 06:05 UTC