Wasmtime GitHub notifications bot (Apr 14 2025 at 18:31): Wasmtime GitHub notifications bot (Apr 14 2025 at 18:31):pchickey opened PR #10578 from bytecodealliance:pch/wit-bindgen-nfcs to bytecodealliance:main:
These changes to wasmtime-wit-bindgen make more functional versions of some of the imperative internal apis for printing datatypes and function types. This PR creates variants of a bunch of these internal functions that drops their
print_prefix and has them return String instead of append to self.src. This is probably worse for performance, but I assume it just doesn't matter for a code generator inside a proc macro.The existing imperative apis (those starting with
print_) still exist, except in the cases where they were dead code- that is, they were only used by other imperative code that was translated to the functional style.
Wasmtime GitHub notifications bot (Apr 14 2025 at 18:31):pchickey requested dicej for a review on PR #10578.
Wasmtime GitHub notifications bot (Apr 14 2025 at 18:31):pchickey requested wasmtime-core-reviewers for a review on PR #10578.
Wasmtime GitHub notifications bot (Apr 14 2025 at 18:32):pchickey requested alexcrichton for a review on PR #10578.
Wasmtime GitHub notifications bot (Apr 14 2025 at 18:32):pchickey requested wasmtime-core-reviewers for a review on PR #10578.
Wasmtime GitHub notifications bot (Apr 14 2025 at 18:32):pchickey updated PR #10578.
Wasmtime GitHub notifications bot (Apr 14 2025 at 19:02):alexcrichton submitted PR review.
Wasmtime GitHub notifications bot (Apr 14 2025 at 20:13):pchickey updated PR #10578.
Wasmtime GitHub notifications bot (Apr 14 2025 at 20:19):pchickey updated PR #10578.
Wasmtime GitHub notifications bot (Apr 15 2025 at 00:11):pchickey merged PR #10578.
Last updated: Dec 06 2025 at 07:03 UTC