Stream: git-wasmtime

Topic: wasmtime / PR #10568 wasmtime-slab: add PartialOrd and Or...

Wasmtime GitHub notifications bot (Apr 11 2025 at 17:02):

cfallin requested wasmtime-core-reviewers for a review on PR #10568.

Wasmtime GitHub notifications bot (Apr 11 2025 at 17:02):

cfallin requested alexcrichton for a review on PR #10568.

Wasmtime GitHub notifications bot (Apr 11 2025 at 17:02):

cfallin opened PR #10568 from cfallin:ordered-slab-ids to bytecodealliance:main:

This became necessary in a use-case where I am using slab IDs as keys in a BTreeMap (as a member of a tuple key type). The actual ordering doesn't carry a fundamental meaning, but overall I do need ordering as the first elements of the tuple have significant ordering and I need to process in order (namely: timer deadlines). The slab ID ordering is at least stable (since the Ids are integers under the hood), and this is useful for anyone who needs to build an ordered key type. The alternative is to use .into_raw() and manually write an Ord impl or use the raw u32 in a key, which is much worse.

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Apr 11 2025 at 17:03):

alexcrichton submitted PR review.

Wasmtime GitHub notifications bot (Apr 11 2025 at 17:04):

alexcrichton has enabled auto merge for PR #10568.

Wasmtime GitHub notifications bot (Apr 11 2025 at 17:44):

cfallin commented on PR #10568:

Merge queue job for Nightly tests failed due to apt install freezing for 25 minutes; retrying.

Wasmtime GitHub notifications bot (Apr 11 2025 at 18:19):

cfallin merged PR #10568.

Last updated: Dec 06 2025 at 07:03 UTC