Stream: git-wasmtime

Topic: wasmtime / PR #10561 Winch: Free dst register if computin...


view this post on Zulip Wasmtime GitHub notifications bot (Apr 09 2025 at 20:59):

jeffcharles opened PR #10561 from jeffcharles:winch-vector-load-fix to bytecodealliance:main:

<!--
Please make sure you include the following information:

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Fixes a bug where a destination register is allocated and not freed when performing a vector load lane from a memory address that is invalid at compilation time. Not freeing the destination register causes an internal compiler error later when emitting code for any result value that uses that register.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 09 2025 at 20:59):

jeffcharles requested abrown for a review on PR #10561.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 09 2025 at 20:59):

jeffcharles requested wasmtime-compiler-reviewers for a review on PR #10561.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 09 2025 at 20:59):

jeffcharles requested dicej for a review on PR #10561.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 09 2025 at 20:59):

jeffcharles requested wasmtime-core-reviewers for a review on PR #10561.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 09 2025 at 21:02):

saulecabrera submitted PR review:

Looks good to me, thanks! Would you mind adding a wast test as well under tests/misc_testsuite/winch?

view this post on Zulip Wasmtime GitHub notifications bot (Apr 09 2025 at 21:09):

jeffcharles updated PR #10561.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 09 2025 at 21:12):

saulecabrera submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 09 2025 at 21:12):

saulecabrera has enabled auto merge for PR #10561.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 09 2025 at 21:44):

saulecabrera merged PR #10561.


Last updated: Jan 09 2026 at 13:15 UTC