Stream: git-wasmtime

Topic: wasmtime / PR #10559 Enable the `unsafe-op-in-unsafe-fn` ...

Wasmtime GitHub notifications bot (Apr 09 2025 at 19:07):

alexcrichton opened PR #10559 from alexcrichton:unsafe-op-in-unsafe-fn to bytecodealliance:main:

This commit enables the unsafe-op-in-unsafe-fn lint in rustc for the entire workspace. This lint will be warn-by-default in the 2024 edition so this is intended to smooth the future migration to the new edition.

Many unsafe blocks were added in places the lint warned about, with two major exceptions. The wasmtime and wasmtime-c-api crates simply expect this lint to fire and effectively disable the lint. They're too big at this time to do through this PR. My hope is that one day in the future they'll be migrated, but more realistically that probably won't happen so these crates just won't benefit from this lint.

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Apr 09 2025 at 19:07):

alexcrichton requested fitzgen for a review on PR #10559.

Wasmtime GitHub notifications bot (Apr 09 2025 at 19:07):

alexcrichton requested wasmtime-compiler-reviewers for a review on PR #10559.

Wasmtime GitHub notifications bot (Apr 09 2025 at 19:07):

alexcrichton requested wasmtime-core-reviewers for a review on PR #10559.

Wasmtime GitHub notifications bot (Apr 09 2025 at 19:07):

alexcrichton requested wasmtime-default-reviewers for a review on PR #10559.

Wasmtime GitHub notifications bot (Apr 09 2025 at 19:09):

alexcrichton updated PR #10559.

Wasmtime GitHub notifications bot (Apr 09 2025 at 19:55):

alexcrichton updated PR #10559.

Wasmtime GitHub notifications bot (Apr 09 2025 at 21:04):

fitzgen submitted PR review.

Wasmtime GitHub notifications bot (Apr 09 2025 at 21:29):

alexcrichton merged PR #10559.

Last updated: Dec 06 2025 at 06:05 UTC