Wasmtime GitHub notifications bot (Apr 08 2025 at 22:42): Wasmtime GitHub notifications bot (Apr 08 2025 at 22:42):cfallin opened PR #10555 from cfallin:fix-riscv64-island-checks to bytecodealliance:main:
In #10502, we introduced changes that could make callsites be arbitrarily long, because they now include loads of return-values-on-stack. We made use of the existing island mechanism (now presented as a new pseudoinst as in aarch64, rather than as ad-hoc emission code) to ensure that we meet label-reference-distance deadlines. Unfortunately we didn't update the debug-assert that checks instructions for worst-case size to exclude calls (and the new
EmitIslandpseudoinst), since they handle islanding separately.Found via fuzzbug at [1].
[1]: https://oss-fuzz.com/testcase-detail/4819793142415360
<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (Apr 08 2025 at 22:42):cfallin requested abrown for a review on PR #10555.
Wasmtime GitHub notifications bot (Apr 08 2025 at 22:42):cfallin requested wasmtime-compiler-reviewers for a review on PR #10555.
Wasmtime GitHub notifications bot (Apr 09 2025 at 00:18):cfallin requested alexcrichton for a review on PR #10555.
Wasmtime GitHub notifications bot (Apr 09 2025 at 00:18):cfallin requested fitzgen for a review on PR #10555.
Wasmtime GitHub notifications bot (Apr 09 2025 at 00:19):alexcrichton submitted PR review.
Wasmtime GitHub notifications bot (Apr 09 2025 at 00:40):alexcrichton merged PR #10555.
Last updated: Dec 06 2025 at 06:05 UTC