Stream: git-wasmtime

Topic: wasmtime / PR #10548 Define an RAII helper for generic ta...

Wasmtime GitHub notifications bot (Apr 08 2025 at 18:24):

fitzgen opened PR #10548 from fitzgen:take-and-replace to bytecodealliance:main:

Follow up to https://github.com/bytecodealliance/wasmtime/pull/10524#discussion_r2032164529

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Apr 08 2025 at 18:24):

fitzgen requested cfallin for a review on PR #10548.

Wasmtime GitHub notifications bot (Apr 08 2025 at 18:24):

fitzgen requested wasmtime-compiler-reviewers for a review on PR #10548.

Wasmtime GitHub notifications bot (Apr 08 2025 at 18:26):

fitzgen updated PR #10548.

Wasmtime GitHub notifications bot (Apr 08 2025 at 19:09):

alexcrichton submitted PR review.

Wasmtime GitHub notifications bot (Apr 08 2025 at 19:09):

alexcrichton created PR review comment:

Perhaps container: &mut T here to emphasize that this isn't intended to take T by ownership? (above it's only instantiated as &mut Self which means it should still compile I think)

Wasmtime GitHub notifications bot (Apr 08 2025 at 19:35):

fitzgen updated PR #10548.

Wasmtime GitHub notifications bot (Apr 08 2025 at 19:35):

fitzgen has enabled auto merge for PR #10548.

Wasmtime GitHub notifications bot (Apr 08 2025 at 20:09):

fitzgen merged PR #10548.

Last updated: Dec 06 2025 at 07:03 UTC