Stream: git-wasmtime

Topic: wasmtime / PR #10547 Beef up documentation about TLS mana...

Wasmtime GitHub notifications bot (Apr 08 2025 at 17:35):

alexcrichton opened PR #10547 from alexcrichton:more-tls-docs to bytecodealliance:main:

This comes out of discussions on the wasip3-prototyping repository where I was trying to re-learn what this all does. The goal here is to more exhaustively document how this module works.

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Apr 08 2025 at 17:35):

alexcrichton requested dicej for a review on PR #10547.

Wasmtime GitHub notifications bot (Apr 08 2025 at 17:35):

alexcrichton requested wasmtime-core-reviewers for a review on PR #10547.

Wasmtime GitHub notifications bot (Apr 08 2025 at 17:44):

dicej submitted PR review:

Very helpful docs and diagram; thanks for doing this!

Wasmtime GitHub notifications bot (Apr 08 2025 at 17:44):

dicej created PR review comment:

FYI, this will no longer be true once CM async support is merged given that concurrent.rs has a couple of TLS variables (and wasmtime-wit-bindgen may also generate code which includes zero or more TLS variables).

Wasmtime GitHub notifications bot (Apr 08 2025 at 17:54):

alexcrichton submitted PR review.

Wasmtime GitHub notifications bot (Apr 08 2025 at 17:54):

alexcrichton created PR review comment:

Hm ok yeah that's going to need to be carefully integrated, "just add a TLS var" breaks portability guarantees we have, so it's not as simple as just relaxing this documentation. We'll have to handle that at some point.

Wasmtime GitHub notifications bot (Apr 08 2025 at 18:15):

alexcrichton merged PR #10547.

Last updated: Dec 06 2025 at 07:03 UTC