Stream: git-wasmtime

Topic: wasmtime / PR #10543 Make a couple `vm::Memory` methods t...

Wasmtime GitHub notifications bot (Apr 07 2025 at 21:22):

fitzgen opened PR #10543 from fitzgen:vm-memory-not-mut-self to bytecodealliance:main:

The &mut self was not necessary and also did not provide any help with using the resulting VMMemoryDefinitions and their raw pointers, so just make these methods take &self.

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Apr 07 2025 at 21:22):

fitzgen requested wasmtime-core-reviewers for a review on PR #10543.

Wasmtime GitHub notifications bot (Apr 07 2025 at 21:22):

fitzgen requested dicej for a review on PR #10543.

Wasmtime GitHub notifications bot (Apr 07 2025 at 21:23):

fitzgen edited PR #10543:

The &mut self was not necessary and also did not provide any help with using the resulting VMMemoryDefinitions and their raw pointers, so just make these methods take &self.

Split off from https://github.com/bytecodealliance/wasmtime/pull/10503

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Apr 07 2025 at 21:25):

dicej submitted PR review.

Wasmtime GitHub notifications bot (Apr 07 2025 at 21:27):

fitzgen updated PR #10543.

Wasmtime GitHub notifications bot (Apr 07 2025 at 21:27):

fitzgen has enabled auto merge for PR #10543.

Wasmtime GitHub notifications bot (Apr 07 2025 at 22:01):

fitzgen merged PR #10543.

Last updated: Dec 06 2025 at 06:05 UTC