Stream: git-wasmtime

Topic: wasmtime / PR #10513 winch(x64): Fix stack parameter algi...


view this post on Zulip Wasmtime GitHub notifications bot (Apr 02 2025 at 19:28):

saulecabrera requested abrown for a review on PR #10513.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 02 2025 at 19:28):

saulecabrera opened PR #10513 from saulecabrera:winch-fuzzbug-v128 to bytecodealliance:main:

Closes https://github.com/bytecodealliance/wasmtime/issues/10460

This commit ensures stack arguments greater than 8 bytes are correctly aligned.

Prior to this commit this wasn't an issue since for the default calling convention, all arguments were aligned to a fixed slot size (e.g, 8 bytes). With the introduction of vector types, namely, v128, we must ensure that arguments greater than 8 bytes in size are correctly type-sized aligned.

<!--
Please make sure you include the following information:

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

view this post on Zulip Wasmtime GitHub notifications bot (Apr 02 2025 at 19:28):

saulecabrera requested wasmtime-compiler-reviewers for a review on PR #10513.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 02 2025 at 19:28):

saulecabrera requested fitzgen for a review on PR #10513.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 02 2025 at 19:28):

saulecabrera requested wasmtime-core-reviewers for a review on PR #10513.


Last updated: Apr 17 2025 at 19:03 UTC