Wasmtime GitHub notifications bot (Apr 01 2025 at 23:43): Wasmtime GitHub notifications bot (Apr 01 2025 at 23:43):fitzgen opened PR #10508 from fitzgen:needs-gc-heap to bytecodealliance:main:
And avoid forcing the allocation of a GC heap for modules that will not use it.
Split out from https://github.com/bytecodealliance/wasmtime/issues/9350
<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (Apr 01 2025 at 23:43):fitzgen requested wasmtime-core-reviewers for a review on PR #10508.
Wasmtime GitHub notifications bot (Apr 01 2025 at 23:43):fitzgen requested pchickey for a review on PR #10508.
Wasmtime GitHub notifications bot (Apr 01 2025 at 23:51):fitzgen updated PR #10508.
Wasmtime GitHub notifications bot (Apr 02 2025 at 00:57):fitzgen updated PR #10508.
Wasmtime GitHub notifications bot (Apr 02 2025 at 01:01):fitzgen updated PR #10508.
Wasmtime GitHub notifications bot (Apr 02 2025 at 02:15):github-actions[bot] commented on PR #10508:
Subscribe to Label Action
cc @fitzgen, @saulecabrera
<details>
This issue or pull request has been labeled: "wasmtime:api", "wasmtime:ref-types", "winch"Thus the following users have been cc'd because of the following labels:
- fitzgen: wasmtime:ref-types
- saulecabrera: winch
To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.
Learn more.
</details>
Wasmtime GitHub notifications bot (Apr 02 2025 at 14:29):alexcrichton submitted PR review:
Thanks for splitting this out!
Wasmtime GitHub notifications bot (Apr 02 2025 at 14:29):alexcrichton created PR review comment:
I think here we might be able to entirely remove the first part of the condition?
Wasmtime GitHub notifications bot (Apr 02 2025 at 15:25):fitzgen updated PR #10508.
Wasmtime GitHub notifications bot (Apr 02 2025 at 15:25):fitzgen has enabled auto merge for PR #10508.
Wasmtime GitHub notifications bot (Apr 02 2025 at 16:40):alexcrichton merged PR #10508.
Last updated: Apr 17 2025 at 23:03 UTC