Wasmtime GitHub notifications bot (Apr 01 2025 at 19:07): Wasmtime GitHub notifications bot (Apr 01 2025 at 19:07):cfallin opened PR #10504 from cfallin:update-regalloc2-0.11.2 to bytecodealliance:main:
This incorporates a fix for a panic caused by too many live registers that is not properly returned as a regalloc error. This condition should not be reachable from Cranelift (which should not generate constraints that trigger this condition), and was seen only during development where different constraints were added; but this PR is an update out of an abundance of caution.
<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (Apr 01 2025 at 19:07):cfallin requested alexcrichton for a review on PR #10504.
Wasmtime GitHub notifications bot (Apr 01 2025 at 19:07):cfallin requested wasmtime-default-reviewers for a review on PR #10504.
Wasmtime GitHub notifications bot (Apr 01 2025 at 19:13):alexcrichton submitted PR review:
r=me, but this'll need a
cargo vettoo
Wasmtime GitHub notifications bot (Apr 01 2025 at 19:16):cfallin commented on PR #10504:
Weirdly, the cargo vet job itself succeeded; it's only the "Cargo vet failed on a Pull Request" job that failed?
Locally,
cargo veton this branch finds no issues either...
Wasmtime GitHub notifications bot (Apr 01 2025 at 19:20):alexcrichton commented on PR #10504:
Oh the vet actually failed but it's allowed to do so to avoid blocking PRs entering the merge queue on the CI check. That way for external contributors we can push vets separately and then merge a PR without requesting a rebase
Wasmtime GitHub notifications bot (Apr 01 2025 at 19:21):alexcrichton commented on PR #10504:
Er, lemme try again with that first link
Wasmtime GitHub notifications bot (Apr 01 2025 at 19:21):alexcrichton commented on PR #10504:
Ok thanks github actions, anyway if you expand the
cargo vet --lockedstep you'll see the failure
Wasmtime GitHub notifications bot (Apr 01 2025 at 19:23):cfallin updated PR #10504.
Wasmtime GitHub notifications bot (Apr 01 2025 at 19:23):cfallin commented on PR #10504:
Ah, that's a bit counterintuitive; thanks, updated.
Wasmtime GitHub notifications bot (Apr 01 2025 at 19:23):cfallin has enabled auto merge for PR #10504.
Wasmtime GitHub notifications bot (Apr 01 2025 at 20:01):cfallin merged PR #10504.
Last updated: Apr 18 2025 at 00:13 UTC