Wasmtime GitHub notifications bot (Apr 01 2025 at 02:05): Wasmtime GitHub notifications bot (Apr 01 2025 at 02:05):abrown opened PR #10499 from abrown:set-more-tables to bytecodealliance:main:
See commit messages for details.
Wasmtime GitHub notifications bot (Apr 01 2025 at 02:05):abrown requested dicej for a review on PR #10499.
Wasmtime GitHub notifications bot (Apr 01 2025 at 02:05):abrown requested wasmtime-core-reviewers for a review on PR #10499.
Wasmtime GitHub notifications bot (Apr 01 2025 at 02:06):abrown submitted PR review.
Wasmtime GitHub notifications bot (Apr 01 2025 at 02:06):abrown created PR review comment:
I'm not really sure what to call this: it is structurally equivalent to a
VMTableImportbut I didn't want to reuse thatstructsince it could confuse things. Suggestions?
Wasmtime GitHub notifications bot (Apr 01 2025 at 14:37):alexcrichton submitted PR review.
Wasmtime GitHub notifications bot (Apr 01 2025 at 14:37):alexcrichton created PR review comment:
I think it'd be reasonable to use
VMTableImportmyself and we could perhaps consider renaming that in the future, basically cutting down on the number of "raw" structures here
Wasmtime GitHub notifications bot (Apr 01 2025 at 16:03):abrown updated PR #10499.
Wasmtime GitHub notifications bot (Apr 01 2025 at 16:03):abrown submitted PR review.
Wasmtime GitHub notifications bot (Apr 01 2025 at 16:03):abrown created PR review comment:
See a2332f7. What do you think about a
VMTableImporttoVMTablerenaming?
Wasmtime GitHub notifications bot (Apr 01 2025 at 16:26):alexcrichton submitted PR review.
Wasmtime GitHub notifications bot (Apr 01 2025 at 16:26):alexcrichton submitted PR review.
Wasmtime GitHub notifications bot (Apr 01 2025 at 16:26):alexcrichton created PR review comment:
Sounds reasonable to me yeah, I'll leave it up to you whether to add that here or merge as-is
Wasmtime GitHub notifications bot (Apr 01 2025 at 18:13):abrown merged PR #10499.
Last updated: Dec 13 2025 at 21:03 UTC