Wasmtime GitHub notifications bot (Mar 31 2025 at 20:57): Wasmtime GitHub notifications bot (Mar 31 2025 at 20:57):abrown requested wasmtime-core-reviewers for a review on PR #10497.
Wasmtime GitHub notifications bot (Mar 31 2025 at 20:57):abrown opened PR #10497 from abrown:set-tables to bytecodealliance:main:
In order to lower the [
thread.spawn_indirect] canonical builtin from the component model, we need to be able to refer to the tables exported from instance. This change adds the initial plumbing to access such tables.[
thread.spawn_indirect]: https://github.com/WebAssembly/component-model/blob/main/design/mvp/CanonicalABI.md#-canon-threadspawn_indirect<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (Mar 31 2025 at 20:57):abrown requested fitzgen for a review on PR #10497.
Wasmtime GitHub notifications bot (Mar 31 2025 at 21:51):alexcrichton submitted PR review.
Wasmtime GitHub notifications bot (Mar 31 2025 at 21:51):alexcrichton created PR review comment:
Mind updating the comment at the top of this file with the pseudo-struct definition to include the table section?
Wasmtime GitHub notifications bot (Mar 31 2025 at 21:51):alexcrichton created PR review comment:
I think this should be
VMTableDefinition, notVMMemoryDefinition
Wasmtime GitHub notifications bot (Mar 31 2025 at 22:06):abrown updated PR #10497.
Wasmtime GitHub notifications bot (Mar 31 2025 at 22:44):abrown merged PR #10497.
Last updated: Apr 18 2025 at 07:03 UTC