Stream: git-wasmtime

Topic: wasmtime / PR #10481 Add documentation for Wasmtime's LTS...


view this post on Zulip Wasmtime GitHub notifications bot (Mar 27 2025 at 20:08):

alexcrichton opened PR #10481 from alexcrichton:lts-documentation to bytecodealliance:main:

With Wasmtime's LTS releases this commit documents the various process changes and updates to our release process. Additionally some improvements are made to the release documentation with respect to showing current versions.

<!--
Please make sure you include the following information:

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

view this post on Zulip Wasmtime GitHub notifications bot (Mar 27 2025 at 20:09):

alexcrichton submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 27 2025 at 20:09):

alexcrichton created PR review comment:

An example of what this generates:

<img width="820" alt="Screenshot 2025-03-27 at 3 08 49 PM" src="https://github.com/user-attachments/assets/36845eaa-ebbb-4790-82b6-524f8b9536b3" />

view this post on Zulip Wasmtime GitHub notifications bot (Mar 27 2025 at 20:10):

alexcrichton commented on PR #10481:

I originally wanted to document the property of "when backporting must update all branches" and got a bit carried away and went ahead and documented the LTS updates.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 27 2025 at 20:13):

alexcrichton updated PR #10481.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 27 2025 at 20:17):

cfallin submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 27 2025 at 20:17):

cfallin created PR review comment:

That is some impressive DOM-tree-editing hackery! The end result looks great.

At the risk of complexifying a little bit: could we add a placeholder ("view this document as HTML in a browser with JavaScript enabled to see contents" or somesuch) so that if the Markdown is processed in some other way -- for example, converted to print pdf by pandoc -- or viewed by a user with JS disabled, they aren't confused?

view this post on Zulip Wasmtime GitHub notifications bot (Mar 27 2025 at 20:20):

fitzgen submitted PR review:

Can you put version numbers in the JS's file paths so that if we ever want/need to upgrade, things are a little easier?

view this post on Zulip Wasmtime GitHub notifications bot (Mar 27 2025 at 20:21):

fitzgen submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 27 2025 at 20:21):

fitzgen created PR review comment:

FYI, you should be able to use a <noscript> tag for this.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 27 2025 at 23:01):

alexcrichton updated PR #10481.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 27 2025 at 23:02):

alexcrichton submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 27 2025 at 23:02):

alexcrichton created PR review comment:

Sounds good yeah, added some <noscript> tags to indicate that it's empty without JS

view this post on Zulip Wasmtime GitHub notifications bot (Mar 31 2025 at 18:49):

alexcrichton has marked PR #10481 as ready for review.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 31 2025 at 18:49):

alexcrichton requested wasmtime-core-reviewers for a review on PR #10481.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 31 2025 at 18:49):

alexcrichton requested dicej for a review on PR #10481.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 31 2025 at 18:49):

alexcrichton requested wasmtime-default-reviewers for a review on PR #10481.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 31 2025 at 19:11):

alexcrichton merged PR #10481.


Last updated: Apr 17 2025 at 02:30 UTC