Wasmtime GitHub notifications bot (Mar 26 2025 at 22:11): Wasmtime GitHub notifications bot (Mar 26 2025 at 22:11):abrown requested wasmtime-compiler-reviewers for a review on PR #10475.
Wasmtime GitHub notifications bot (Mar 26 2025 at 22:11):abrown requested cfallin for a review on PR #10475.
Wasmtime GitHub notifications bot (Mar 26 2025 at 22:11):abrown opened PR #10475 from abrown:asm-prefixes to bytecodealliance:main:
Previously, Cranelift's x64 backend only understood a subset of the available prefixes that can be encoded and the documentation for these was quite sparse. This change upgrades the assembler to understand all kinds of prefixes, even those as yet unused, and drastically increases the amount of documentation around these prefixes. This, along with some new
Group-based typing, should prevent accidental misuse but also increase confidence that this implementation is correctly covering the possible cases.<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (Mar 26 2025 at 23:37):cfallin submitted PR review:
Looks good!
Wasmtime GitHub notifications bot (Mar 26 2025 at 23:37):cfallin created PR review comment:
while bytes.len() > 0 && prefixes.try_assign(bytes[0]).is_ok()?(I think this won't matter as long as you only pass in slices that end in true opcodes, and no opcode has the same value as a prefix, but it caught my eye as that's quite subtle)
Wasmtime GitHub notifications bot (Mar 26 2025 at 23:47):abrown updated PR #10475.
Wasmtime GitHub notifications bot (Mar 26 2025 at 23:48):abrown has enabled auto merge for PR #10475.
Wasmtime GitHub notifications bot (Mar 27 2025 at 00:24):abrown merged PR #10475.
Last updated: Apr 18 2025 at 05:03 UTC