Wasmtime GitHub notifications bot (Mar 26 2025 at 21:26): Wasmtime GitHub notifications bot (Mar 26 2025 at 21:26):alexcrichton opened PR #10473 from alexcrichton:fix-panic-with-tags to bytecodealliance:main:
This commit resolves a few panics in Wasmtime's compilation of components with respect to tags and the exception-handling wasm proposal. Despite exception-handling not being enabled in Wasmtime at this time these panics were still reachable due to an issue in wasm-tools's validation not being exhaustive enough for this proposal feature combination: bytecodealliance/wasm-tools#2114.
This is not full support for exceptions since it can't be tested yet, but this should be enough to ensure that the validator will get far enough to flag components as otherwise invalid due to using tags that can't be present (as core wasm tags can't be present in core modules right now, the
EXCEPTIONSfeature is always disabled).
Wasmtime GitHub notifications bot (Mar 26 2025 at 21:26):alexcrichton requested dicej for a review on PR #10473.
Wasmtime GitHub notifications bot (Mar 26 2025 at 21:26):alexcrichton requested wasmtime-core-reviewers for a review on PR #10473.
Wasmtime GitHub notifications bot (Mar 26 2025 at 21:26):alexcrichton commented on PR #10473:
Thanks to @0xalpharush for discovering this issue and letting us know!
Wasmtime GitHub notifications bot (Mar 26 2025 at 21:28):dicej submitted PR review.
Wasmtime GitHub notifications bot (Mar 26 2025 at 21:29):alexcrichton has enabled auto merge for PR #10473.
Wasmtime GitHub notifications bot (Mar 26 2025 at 22:02):alexcrichton merged PR #10473.
Last updated: Apr 18 2025 at 21:03 UTC