Wasmtime GitHub notifications bot (Mar 25 2025 at 20:04): Wasmtime GitHub notifications bot (Mar 25 2025 at 20:04):fitzgen requested alexcrichton for a review on PR #10470.
Wasmtime GitHub notifications bot (Mar 25 2025 at 20:04):fitzgen requested wasmtime-core-reviewers for a review on PR #10470.
Wasmtime GitHub notifications bot (Mar 25 2025 at 20:04):fitzgen opened PR #10470 from fitzgen:issue-10467 to bytecodealliance:main:
Note: Depends on https://github.com/bytecodealliance/wasmtime/pull/10463 to avoid conflicts in
disasoutput updates.We were incorrectly reusing the offset of the first-element-to-be-filled's
address (index * size_of(elem)) as the size-in-bytes of the whole fill (which
should actually ben * size_of(elem)). This led to the wrong number of
iterations for our element-filling loop.Fixes #10467
Wasmtime GitHub notifications bot (Mar 25 2025 at 21:44):github-actions[bot] commented on PR #10470:
Subscribe to Label Action
cc @fitzgen
<details>
This issue or pull request has been labeled: "wasmtime:api", "wasmtime:ref-types"Thus the following users have been cc'd because of the following labels:
- fitzgen: wasmtime:ref-types
To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.
Learn more.
</details>
Wasmtime GitHub notifications bot (Mar 25 2025 at 23:37):fitzgen updated PR #10470.
Wasmtime GitHub notifications bot (Mar 25 2025 at 23:39):fitzgen updated PR #10470.
Wasmtime GitHub notifications bot (Mar 25 2025 at 23:40):fitzgen edited PR #10470:
We were incorrectly reusing the offset of the first-element-to-be-filled's address (
index * size_of(elem)) as the size-in-bytes of the whole fill (which should actually ben * size_of(elem)). This led to the wrong number of iterations for our element-filling loop.Fixes #10467
Wasmtime GitHub notifications bot (Mar 26 2025 at 14:31):alexcrichton submitted PR review.
Wasmtime GitHub notifications bot (Mar 26 2025 at 14:54):alexcrichton merged PR #10470.
Last updated: Apr 17 2025 at 22:03 UTC