Wasmtime GitHub notifications bot (Mar 25 2025 at 15:58): Wasmtime GitHub notifications bot (Mar 25 2025 at 15:58):cfallin requested abrown for a review on PR #10466.
Wasmtime GitHub notifications bot (Mar 25 2025 at 15:58):cfallin requested wasmtime-compiler-reviewers for a review on PR #10466.
Wasmtime GitHub notifications bot (Mar 25 2025 at 15:58):cfallin opened PR #10466 from cfallin:isle-source-dir-tweaks to bytecodealliance:main:
- Add a
cargo:rerun-if-env-changedclause for theISLE_SOURCE_DIRenvironment variable to properly rebuild if the config changes.- Update docs to point to the new env-var-based approach rather than the old Cargo feature.
As per this Zulip conversation [1] and this GitHub comment [2].
[1]: https://bytecodealliance.zulipchat.com/#narrow/channel/217117-cranelift/topic/How.20to.20enable.20the.20isle-in-source-tree.20feature.3F/near/508028830
[2]: https://github.com/bytecodealliance/wasmtime/pull/9633#discussion_r2012230673<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (Mar 25 2025 at 16:21):abrown submitted PR review.
Wasmtime GitHub notifications bot (Mar 25 2025 at 16:44):abrown merged PR #10466.
Last updated: Apr 18 2025 at 01:31 UTC