Stream: git-wasmtime

Topic: wasmtime / PR #10461 Remove some unnecessary `UnsafeCell`...

Wasmtime GitHub notifications bot (Mar 24 2025 at 22:45):

fitzgen requested alexcrichton for a review on PR #10461.

Wasmtime GitHub notifications bot (Mar 24 2025 at 22:45):

fitzgen opened PR #10461 from fitzgen:remove-unnecessary-unsafe-cells-in-gc-runtime-code to bytecodealliance:main:

None of these are actually mutated while behind shared references. Everything, including interactions with JIT code, obeys Rust's borrowing rules. Running tests under MIRI still passes, verifying these claims. Therefore, we can remove these UnsafeCells, which makes the code much easier to read and much less footgun-y since there is less unsafe code and less working with UnsafeCells' raw pointers.

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Mar 24 2025 at 22:45):

fitzgen requested wasmtime-core-reviewers for a review on PR #10461.

Wasmtime GitHub notifications bot (Mar 24 2025 at 23:23):

fitzgen updated PR #10461.

Wasmtime GitHub notifications bot (Mar 24 2025 at 23:28):

alexcrichton submitted PR review.

Wasmtime GitHub notifications bot (Mar 24 2025 at 23:28):

alexcrichton created PR review comment:

debugging code I think?

Wasmtime GitHub notifications bot (Mar 24 2025 at 23:28):

alexcrichton created PR review comment:

Drive-by review for unrelated code, SendSyncPtr can remove the need for these

Wasmtime GitHub notifications bot (Mar 24 2025 at 23:28):

alexcrichton created PR review comment:

More drive-by review: perhaps adding an unsafe fn as_slice(&self) to Mmap? (same for above for the drc heap)

Wasmtime GitHub notifications bot (Mar 24 2025 at 23:29):

fitzgen updated PR #10461.

Wasmtime GitHub notifications bot (Mar 24 2025 at 23:42):

fitzgen updated PR #10461.

Wasmtime GitHub notifications bot (Mar 24 2025 at 23:44):

fitzgen has enabled auto merge for PR #10461.

Wasmtime GitHub notifications bot (Mar 25 2025 at 00:22):

fitzgen merged PR #10461.

Last updated: Apr 18 2025 at 09:03 UTC