Stream: git-wasmtime

Topic: wasmtime / PR #10458 Avoid some unnecessary reduces and e...

Wasmtime GitHub notifications bot (Mar 21 2025 at 22:51):

fitzgen opened PR #10458 from fitzgen:gc-ref-libcalls-u32-abi to bytecodealliance:main:

We are logically returning a VMGcRef from these libcalls, which is a NonZeroU32 under the covers. We were representing that value as a u32, and then to represent traps and panics, we packed that into a u64 and if the u64 was negative that meant there was a trap/panic but otherwise we could unpack the bottom half and that was our result.

But because our GC refs are non-zero, we don't need to extend to a u64 to get a sentinel for traps/panics; we can just use zero. That's what this commit does.

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Mar 21 2025 at 22:51):

fitzgen requested dicej for a review on PR #10458.

Wasmtime GitHub notifications bot (Mar 21 2025 at 22:51):

fitzgen requested wasmtime-core-reviewers for a review on PR #10458.

Wasmtime GitHub notifications bot (Mar 21 2025 at 23:44):

github-actions[bot] commented on PR #10458:

Subscribe to Label Action

cc @fitzgen

<details>
This issue or pull request has been labeled: "wasmtime:api", "wasmtime:ref-types"

Thus the following users have been cc'd because of the following labels:

• fitzgen: wasmtime:ref-types

To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.

Learn more.
</details>

Wasmtime GitHub notifications bot (Mar 21 2025 at 23:54):

alexcrichton submitted PR review.

Wasmtime GitHub notifications bot (Mar 22 2025 at 00:16):

alexcrichton merged PR #10458.

Last updated: Apr 18 2025 at 09:03 UTC