Stream: git-wasmtime

Topic: wasmtime / PR #10446 asm: notate instruction alignment, S...

Wasmtime GitHub notifications bot (Mar 21 2025 at 01:49):

abrown opened PR #10446 from abrown:asm-alignment to bytecodealliance:main:

This change improves the definitions of the assembler's SSE instructions in two ways:

• vector instructions that require aligned memory accesses (i.e., most everything pre-AVX) are now noted with an align attribute in the AST. This is used for generating the expected XmmMemAligned types in cranelift-codegen-meta the "right way," resolving the temporary fix introduced in #10417.
• previously-added vector instructions did not have the correct feature flags; this change adds the sse feature and also tags the applicable instructions with the compat feature to allow their use in some future 32-bit target.

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Mar 21 2025 at 01:49):

abrown requested cfallin for a review on PR #10446.

Wasmtime GitHub notifications bot (Mar 21 2025 at 01:49):

abrown requested wasmtime-compiler-reviewers for a review on PR #10446.

Wasmtime GitHub notifications bot (Mar 24 2025 at 17:11):

cfallin submitted PR review:

LGTM, thanks!

Wasmtime GitHub notifications bot (Mar 24 2025 at 17:11):

cfallin created PR review comment:

Should we dedup here (e.g. check if in list already before adding)?

Wasmtime GitHub notifications bot (Mar 24 2025 at 20:31):

abrown updated PR #10446.

Wasmtime GitHub notifications bot (Mar 24 2025 at 20:32):

abrown has enabled auto merge for PR #10446.

Wasmtime GitHub notifications bot (Mar 24 2025 at 21:09):

abrown merged PR #10446.

Last updated: Apr 18 2025 at 10:03 UTC