Stream: git-wasmtime

Topic: wasmtime / PR #10436 Remove `wasmtime_fuzzing::oracles::d...

Wasmtime GitHub notifications bot (Mar 20 2025 at 19:20):

fitzgen opened PR #10436 from fitzgen:use-dummy-method-of-linker-in-fuzzer to bytecodealliance:main:

Since that helper was written, we now have this same functionality built into wasmtime::Linker.

Unfortunately, we can't remove most of the dummy module, because it is used by the api_calls fuzzer to create dummy wasmtime::Externs and we don't have off-the-shelf helpers for doing that in the core wasmtime API for that yet.

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Mar 20 2025 at 19:20):

fitzgen requested wasmtime-fuzz-reviewers for a review on PR #10436.

Wasmtime GitHub notifications bot (Mar 20 2025 at 19:20):

fitzgen requested alexcrichton for a review on PR #10436.

Wasmtime GitHub notifications bot (Mar 20 2025 at 19:27):

alexcrichton commented on PR #10436:

I think this may not reduce the efficacy of fuzzing because the Linker-based version only handles functions while dummy handles everything?

Wasmtime GitHub notifications bot (Mar 20 2025 at 19:29):

fitzgen commented on PR #10436:

Unfortunately, we can't remove most of the dummy module, because it is used by the api_calls fuzzer to create dummy wasmtime::Externs and we don't have off-the-shelf helpers for doing that in the core wasmtime API for that yet.

Filed https://github.com/bytecodealliance/wasmtime/issues/10437 for cleaning this stuff up.

Wasmtime GitHub notifications bot (Mar 20 2025 at 19:30):

fitzgen commented on PR #10436:

I think this may not reduce the efficacy of fuzzing because the Linker-based version only handles functions while dummy handles everything?

Ah, I didn't realize that the linker method only handled functions. Is there a particular reason we didn't do all extern types?

Wasmtime GitHub notifications bot (Mar 20 2025 at 19:33):

alexcrichton commented on PR #10436:

IIRC it's because it was added from a CLI-centric perspective at the time where most modules don't import globals/memories/etc. I think it'd be reasonable to add support though.

Wasmtime GitHub notifications bot (Mar 20 2025 at 19:45):

fitzgen commented on PR #10436:

Ah it is because we don't have a Store in the Linker but we need one to create e.g. Globals.

Wasmtime GitHub notifications bot (Mar 20 2025 at 19:45):

fitzgen closed without merge PR #10436.

Wasmtime GitHub notifications bot (Mar 20 2025 at 19:45):

fitzgen commented on PR #10436:

Probably not worth pursuing this PR any further then.

Last updated: Apr 17 2025 at 08:04 UTC