wasmtime / PR #10429 Draft: Expose Wasi-TLS handshake error · git-wasmtime

You mean the table entries for the newly created wasi:io/error resources? The ownership of these resource is transferred into the guest one line below it. It's then the responsibility of the guest to drop it properly like any other resource. When the guest drops that resource, wasmtime removes it from the table in https://github.com/bytecodealliance/wasmtime/blob/main/crates/wasi-io/src/impls.rs#L114-L116

Wasmtime GitHub notifications bot (Mar 20 2025 at 18:04):

jsturtevant submitted PR review.

Wasmtime GitHub notifications bot (Mar 20 2025 at 18:04):

jsturtevant created PR review comment:

thanks for the explanation

Wasmtime GitHub notifications bot (Mar 20 2025 at 19:52):

badeend updated PR #10429.

Wasmtime GitHub notifications bot (Mar 20 2025 at 19:54):

badeend edited PR #10429:

Implements https://github.com/WebAssembly/wasi-tls/pull/10

And added a test case to verify the error information is indeed reaching the guest.

~PR is still draft, because above issue needs to be merged first. But feel free to review the design & implementation already.~

CC @jsturtevant

Wasmtime GitHub notifications bot (Mar 20 2025 at 19:54):

badeend has marked PR #10429 as ready for review.

Wasmtime GitHub notifications bot (Mar 20 2025 at 19:54):

badeend requested wasmtime-default-reviewers for a review on PR #10429.

Last updated: Apr 22 2025 at 16:04 UTC