Stream: git-wasmtime

Topic: wasmtime / PR #10390 Remove support for is_pic

view this post on Zulip Wasmtime GitHub notifications bot (Mar 13 2025 at 11:15):

bjorn3 opened PR #10390 from bjorn3:remove_cranelift_jit_pic_handling to bytecodealliance:main:

It didn't support non-x86_64 targets anyway and adds a fair amount of complexity. There is no benefit to PIC code when jitting either.

Closes https://github.com/bytecodealliance/wasmtime/issues/2735

view this post on Zulip Wasmtime GitHub notifications bot (Mar 13 2025 at 11:17):

bjorn3 commented on PR #10390:

Marked as draft as I would like to first see the next Cranelift version get released for https://github.com/bytecodealliance/wasmtime/pull/10347 to know for sure that cg_clif works with !is_pic in the jit mode.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 13 2025 at 11:45):

bjorn3 commented on PR #10390:

Spurious CI failure?

view this post on Zulip Wasmtime GitHub notifications bot (Mar 13 2025 at 12:39):

bjorn3 edited PR #10390:

It didn't support non-x86_64 targets anyway and adds a fair amount of complexity. There is no benefit to PIC code when jitting either.

Follow up to https://github.com/bytecodealliance/wasmtime/pull/10345
Closes https://github.com/bytecodealliance/wasmtime/issues/2735

view this post on Zulip Wasmtime GitHub notifications bot (Mar 13 2025 at 14:30):

primoly commented on PR #10390:

The CI failure originates from #10387. The tests introduced there fail only sometimes. I would love to fix the issue, but since I don’t know the cause, it would just be random shots in the dark.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 13 2025 at 16:02):

alexcrichton commented on PR #10390:

I believe I've tracked down that sissue and @primoly I don't think the fault actually lies in your PR, it's preexisting infrastructural problems with the tests. I'll re-run the build here.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 13 2025 at 19:14):

alexcrichton commented on PR #10390:

(specifically https://github.com/bytecodealliance/wasmtime/pull/10394 should solve that flaky test)

view this post on Zulip Wasmtime GitHub notifications bot (Mar 20 2025 at 15:48):

bjorn3 updated PR #10390.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 20 2025 at 17:03):

bjorn3 has marked PR #10390 as ready for review.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 20 2025 at 17:03):

bjorn3 requested abrown for a review on PR #10390.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 20 2025 at 17:03):

bjorn3 requested wasmtime-compiler-reviewers for a review on PR #10390.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 20 2025 at 17:03):

bjorn3 commented on PR #10390:

cg_clif has updated to Cranelift 0.118 and disabled is_pic usage for the JIT mode without issues.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 20 2025 at 19:04):

abrown submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 20 2025 at 19:25):

abrown merged PR #10390.

Last updated: Apr 17 2025 at 01:31 UTC