Stream: git-wasmtime

Topic: wasmtime / PR #10384 Change `allow(missing_docs)` to `exp...

Wasmtime GitHub notifications bot (Mar 12 2025 at 15:17):

alexcrichton opened PR #10384 from alexcrichton:expect-missing-docs to bytecodealliance:main:

This wasn't possible when expect was first introduced due to a change being required in upstream rust-lang/rust. That change rust-lang/rust#130025) has now rode enough trains to be in our MSRV, so we can expect missing docs now instead of just allowing it.

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Mar 12 2025 at 15:17):

alexcrichton requested wasmtime-compiler-reviewers for a review on PR #10384.

Wasmtime GitHub notifications bot (Mar 12 2025 at 15:17):

alexcrichton requested wasmtime-default-reviewers for a review on PR #10384.

Wasmtime GitHub notifications bot (Mar 12 2025 at 15:17):

alexcrichton requested dicej for a review on PR #10384.

Wasmtime GitHub notifications bot (Mar 12 2025 at 15:17):

alexcrichton requested cfallin for a review on PR #10384.

Wasmtime GitHub notifications bot (Mar 12 2025 at 15:17):

alexcrichton requested wasmtime-core-reviewers for a review on PR #10384.

Wasmtime GitHub notifications bot (Mar 12 2025 at 15:37):

dicej submitted PR review.

Wasmtime GitHub notifications bot (Mar 12 2025 at 15:37):

dicej created PR review comment:

How is this file related to the rest of the PR?

Wasmtime GitHub notifications bot (Mar 12 2025 at 16:14):

alexcrichton submitted PR review.

Wasmtime GitHub notifications bot (Mar 12 2025 at 16:14):

alexcrichton created PR review comment:

Oops it is not, just me being bad at git

Wasmtime GitHub notifications bot (Mar 12 2025 at 17:45):

github-actions[bot] commented on PR #10384:

Subscribe to Label Action

cc @fitzgen

<details>
This issue or pull request has been labeled: "cranelift", "cranelift:module", "pulley"

Thus the following users have been cc'd because of the following labels:

• fitzgen: pulley

To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.

Learn more.
</details>

Wasmtime GitHub notifications bot (Mar 12 2025 at 18:41):

alexcrichton updated PR #10384.

Wasmtime GitHub notifications bot (Mar 12 2025 at 18:41):

alexcrichton has enabled auto merge for PR #10384.

Wasmtime GitHub notifications bot (Mar 12 2025 at 19:26):

alexcrichton merged PR #10384.

Last updated: Apr 18 2025 at 08:04 UTC