Wasmtime GitHub notifications bot (Mar 12 2025 at 00:09): Wasmtime GitHub notifications bot (Mar 12 2025 at 00:09):jsturtevant requested fitzgen for a review on PR #10377.
Wasmtime GitHub notifications bot (Mar 12 2025 at 00:09):jsturtevant opened PR #10377 from jsturtevant:add-second-endpoint to bytecodealliance:main:
<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->Helps address https://github.com/bytecodealliance/wasmtime/issues/10369 by adding a second endpoint. One reason for testing the external endpoint is to make sure the set up of the system cert store works when calling external sites, so this preserves that but should also help the tests be less flakey.
Wasmtime GitHub notifications bot (Mar 12 2025 at 00:09):jsturtevant requested wasmtime-core-reviewers for a review on PR #10377.
Wasmtime GitHub notifications bot (Mar 12 2025 at 00:27):alexcrichton submitted PR review.
Wasmtime GitHub notifications bot (Mar 12 2025 at 00:27):alexcrichton created PR review comment:
Should this avoid a
.unwrap()here since I think that would translate to both domains being required to succeed instead of just one?
Wasmtime GitHub notifications bot (Mar 12 2025 at 00:31):jsturtevant submitted PR review.
Wasmtime GitHub notifications bot (Mar 12 2025 at 00:31):jsturtevant created PR review comment:
yes, I had that at initially and was trying something else and forgot to go back:face_palm:
Wasmtime GitHub notifications bot (Mar 12 2025 at 04:18):jsturtevant updated PR #10377.
Wasmtime GitHub notifications bot (Mar 12 2025 at 04:19):jsturtevant submitted PR review.
Wasmtime GitHub notifications bot (Mar 12 2025 at 04:19):jsturtevant created PR review comment:
updated
Wasmtime GitHub notifications bot (Mar 12 2025 at 04:19):jsturtevant updated PR #10377.
Wasmtime GitHub notifications bot (Mar 12 2025 at 04:20):jsturtevant edited PR #10377:
<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->Helps address https://github.com/bytecodealliance/wasmtime/issues/10369 by adding a second endpoint. One reason for testing the external endpoint is to make sure the set up of the system cert store works when calling external sites, so this preserves the external call but should also help the tests be less flakey.
Wasmtime GitHub notifications bot (Mar 12 2025 at 16:56):jsturtevant updated PR #10377.
Wasmtime GitHub notifications bot (Mar 12 2025 at 18:43):alexcrichton submitted PR review.
Wasmtime GitHub notifications bot (Mar 12 2025 at 19:26):alexcrichton merged PR #10377.
Last updated: Apr 18 2025 at 14:03 UTC