Stream: git-wasmtime

Topic: wasmtime / PR #10375 Make `GcStore::expose_gc_ref_to_wasm...

Wasmtime GitHub notifications bot (Mar 11 2025 at 23:52):

fitzgen opened PR #10375 from fitzgen:expose-gc-ref-to-wasm-returns-raw-repr to bytecodealliance:main:

Every caller of expose_gc_ref_to_wasm except for one does this weird dance where they get the raw representation of the GC ref before giving up ownership of it to the expose_gc_ref_to_wasm call, and then do something with the raw GC ref (like return it to Wasm or whatever).

This small refactoring boxes up that dance inside expose_gc_ref_to_wasm so that callers don't have to do it themselves anymore. Makes things that much more concise and harder to mess up.

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Mar 11 2025 at 23:52):

fitzgen requested wasmtime-core-reviewers for a review on PR #10375.

Wasmtime GitHub notifications bot (Mar 11 2025 at 23:52):

fitzgen requested dicej for a review on PR #10375.

Wasmtime GitHub notifications bot (Mar 12 2025 at 02:00):

alexcrichton submitted PR review.

Wasmtime GitHub notifications bot (Mar 12 2025 at 02:21):

alexcrichton merged PR #10375.

Last updated: Apr 17 2025 at 22:03 UTC