Wasmtime GitHub notifications bot (Mar 11 2025 at 18:36): Wasmtime GitHub notifications bot (Mar 11 2025 at 18:36):fitzgen requested alexcrichton for a review on PR #10372.
Wasmtime GitHub notifications bot (Mar 11 2025 at 18:36):fitzgen opened PR #10372 from fitzgen:issue-10353 to bytecodealliance:main:
As an optimization, we were previously avoiding the load and instead simply materializing the null reference value, since that is the only value that inhabits
(ref null none). However, in certain situations, such as when loading from a table when Spectre mitigations are enabled, we rely on that load being attempted and resulting in a trap if the table index is out of bounds. This commit makes it so that we will always perform the load if our givenir::MemFlagscan trap.Fixes #10353
<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (Mar 11 2025 at 18:36):fitzgen requested wasmtime-core-reviewers for a review on PR #10372.
Wasmtime GitHub notifications bot (Mar 11 2025 at 19:22):alexcrichton submitted PR review.
Wasmtime GitHub notifications bot (Mar 11 2025 at 19:44):github-actions[bot] commented on PR #10372:
Subscribe to Label Action
cc @fitzgen
<details>
This issue or pull request has been labeled: "wasmtime:ref-types"Thus the following users have been cc'd because of the following labels:
- fitzgen: wasmtime:ref-types
To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.
Learn more.
</details>
Wasmtime GitHub notifications bot (Mar 11 2025 at 20:25):fitzgen merged PR #10372.
Last updated: Apr 18 2025 at 12:05 UTC