Wasmtime GitHub notifications bot (Mar 11 2025 at 15:07): Wasmtime GitHub notifications bot (Mar 11 2025 at 15:07):jeffcharles opened PR #10370 from jeffcharles:winch-simd-issue-10357 to bytecodealliance:main:
<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Fixes #10357. There's a subtle bug with the existingmemmoveimplementation where if aHighToLowmemmoveis being performed and the source and destination offsets overlap and more than 8 bytes are being moved, then part of the data is copied multiple times into different destination offsets. Performing the move in the opposite direction fixes the problem.
Wasmtime GitHub notifications bot (Mar 11 2025 at 15:07):jeffcharles requested abrown for a review on PR #10370.
Wasmtime GitHub notifications bot (Mar 11 2025 at 15:07):jeffcharles requested wasmtime-compiler-reviewers for a review on PR #10370.
Wasmtime GitHub notifications bot (Mar 11 2025 at 15:07):jeffcharles requested wasmtime-core-reviewers for a review on PR #10370.
Wasmtime GitHub notifications bot (Mar 11 2025 at 15:07):jeffcharles requested pchickey for a review on PR #10370.
Wasmtime GitHub notifications bot (Mar 11 2025 at 15:22):saulecabrera commented on PR #10370:
I'll take a look at this one.
Wasmtime GitHub notifications bot (Mar 11 2025 at 15:22):saulecabrera requested saulecabrera for a review on PR #10370.
Wasmtime GitHub notifications bot (Mar 11 2025 at 16:48):github-actions[bot] commented on PR #10370:
Subscribe to Label Action
cc @saulecabrera
<details>
This issue or pull request has been labeled: "winch"Thus the following users have been cc'd because of the following labels:
- saulecabrera: winch
To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.
Learn more.
</details>
Wasmtime GitHub notifications bot (Mar 11 2025 at 23:29):saulecabrera submitted PR review:
LGTM,thanks. I'll run the fuzzer locally for a bit before landing.
Wasmtime GitHub notifications bot (Mar 12 2025 at 11:48):saulecabrera commented on PR #10370:
Ran the fuzzer over night and nothing was reported.
Wasmtime GitHub notifications bot (Mar 12 2025 at 12:09):saulecabrera merged PR #10370.
Last updated: Apr 18 2025 at 08:04 UTC