Stream: git-wasmtime

Topic: wasmtime / PR #10368 Derive serde on EntitySet when featu...

Wasmtime GitHub notifications bot (Mar 10 2025 at 21:01):

djmarcin opened PR #10368 from djmarcin:main to bytecodealliance:main:

Fixes #10367

Wasmtime GitHub notifications bot (Mar 10 2025 at 21:22):

cfallin submitted PR review:

Looks reasonable -- as you say I don't think there's any reason this isn't here today except that no one has needed it.

I think you'll need to add the feature itself and the serde/serde_derive dependencies to the cranelift-entity crate (see the cranelift-bitset crate's Cargo.toml for an example). Could you add a cargo check invocation to CI to test this option as well?

Wasmtime GitHub notifications bot (Mar 10 2025 at 21:34):

djmarcin updated PR #10368.

Wasmtime GitHub notifications bot (Mar 10 2025 at 21:35):

djmarcin commented on PR #10368:

I believe the cranelift-entity crate is already using these deps/features, it's just not on this struct.

I'm not familiar with the structure of your workflows, is this what you wanted?

Wasmtime GitHub notifications bot (Mar 10 2025 at 21:35):

djmarcin has marked PR #10368 as ready for review.

Wasmtime GitHub notifications bot (Mar 10 2025 at 21:35):

djmarcin requested fitzgen for a review on PR #10368.

Wasmtime GitHub notifications bot (Mar 10 2025 at 21:35):

djmarcin requested wasmtime-compiler-reviewers for a review on PR #10368.

Wasmtime GitHub notifications bot (Mar 10 2025 at 21:35):

djmarcin requested wasmtime-default-reviewers for a review on PR #10368.

Wasmtime GitHub notifications bot (Mar 10 2025 at 21:37):

cfallin submitted PR review:

Looks good, thanks!

Wasmtime GitHub notifications bot (Mar 10 2025 at 21:37):

cfallin has enabled auto merge for PR #10368.

Wasmtime GitHub notifications bot (Mar 10 2025 at 22:10):

cfallin merged PR #10368.

Last updated: Apr 17 2025 at 23:03 UTC