Stream: git-wasmtime

Topic: wasmtime / PR #10366 Enable async support in wast tests

Wasmtime GitHub notifications bot (Mar 10 2025 at 20:32):

alexcrichton requested fitzgen for a review on PR #10366.

Wasmtime GitHub notifications bot (Mar 10 2025 at 20:32):

alexcrichton opened PR #10366 from alexcrichton:wast-async to bytecodealliance:main:

This commit updates the wasmtime-wast crate to conditionally use the Config::async_support mode of Wasmtime, notably executing instantiate_async and call_async. At this time no actual concurrency is supported and everything is immediately await'd on via block_on and a local single-thread tokio runtime.

The motivation for this commit is that in the upcoming implementation of WASIp3 async will effectively be the only way to invoke components. Furthermore to test these components we're wanting to use async APIs as the root of invocations for writing *.wast tests for testing component-model async features.

In enabling this support this commit additionally updates the wast_tests fuzzer to execute all tests both with and without async. Effectively the async configuration is now a fuzz option, meaning that all tests are being executed with async now as well to ensure that they work (yay!).

The --test wast testing mode and wasmtime wast CLI command are both updated to unconditionally use async. There should be no loss in test coverage due to the fuzzer update, and right now knobs aren't provided to conditionally use sync in these two modes, again because it's currently expected that this won't be able to run component model async tests, so the defaults are changing.

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Mar 10 2025 at 20:32):

alexcrichton requested wasmtime-core-reviewers for a review on PR #10366.

Wasmtime GitHub notifications bot (Mar 10 2025 at 20:32):

alexcrichton requested wasmtime-fuzz-reviewers for a review on PR #10366.

Wasmtime GitHub notifications bot (Mar 10 2025 at 20:32):

alexcrichton requested wasmtime-default-reviewers for a review on PR #10366.

Wasmtime GitHub notifications bot (Mar 10 2025 at 21:44):

github-actions[bot] commented on PR #10366:

Subscribe to Label Action

cc @fitzgen

<details>
This issue or pull request has been labeled: "fuzzing"

Thus the following users have been cc'd because of the following labels:

• fitzgen: fuzzing

To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.

Learn more.
</details>

Wasmtime GitHub notifications bot (Mar 11 2025 at 02:36):

pchickey submitted PR review.

Wasmtime GitHub notifications bot (Mar 11 2025 at 15:05):

alexcrichton has enabled auto merge for PR #10366.

Wasmtime GitHub notifications bot (Mar 11 2025 at 15:05):

alexcrichton updated PR #10366.

Wasmtime GitHub notifications bot (Mar 11 2025 at 15:41):

alexcrichton merged PR #10366.

Last updated: Apr 16 2025 at 15:03 UTC