Stream: git-wasmtime

Topic: wasmtime / PR #10365 Move `assembler.isle` to "untracked ...

Wasmtime GitHub notifications bot (Mar 10 2025 at 19:39):

alexcrichton opened PR #10365 from alexcrichton:rerun-if-changed to bytecodealliance:main:

This fixes a minor issue from #10352 where because assembler.isle was written by the build script itself by including it in the "tracked inputs" it meant that the build script always re-ran, never caching the output. This commit moves the file to the "untracked inputs" which means that while it's used by ISLE it won't be passed to Cargo as input since it's generated in-process. This re-enables cargo build not doing anything after a successful build.

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Mar 10 2025 at 19:39):

alexcrichton requested cfallin for a review on PR #10365.

Wasmtime GitHub notifications bot (Mar 10 2025 at 19:39):

alexcrichton requested wasmtime-compiler-reviewers for a review on PR #10365.

Wasmtime GitHub notifications bot (Mar 10 2025 at 19:52):

cfallin submitted PR review.

Wasmtime GitHub notifications bot (Mar 10 2025 at 19:52):

cfallin has enabled auto merge for PR #10365.

Wasmtime GitHub notifications bot (Mar 10 2025 at 21:49):

cfallin merged PR #10365.

Last updated: Apr 18 2025 at 14:03 UTC