Stream: git-wasmtime

Topic: wasmtime / PR #10360 feat: Add hexadecimal integer parsin...

view this post on Zulip Wasmtime GitHub notifications bot (Mar 08 2025 at 19:32):

VolodymyrBg requested alexcrichton for a review on PR #10360.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 08 2025 at 19:32):

VolodymyrBg opened PR #10360 from VolodymyrBg:BG to bytecodealliance:main:

Previously, the CLI interface would only accept base-10 (decimal) integers when
passing arguments to WebAssembly functions. This change adds support for
hexadecimal notation with the '0x' prefix.

Now users can pass hexadecimal values directly to functions that expect integer
arguments, making it more convenient to work with bit patterns, addresses, and
other values commonly represented in hexadecimal format.

Fixes the TODO comment in the run.rs file that requested this feature.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 08 2025 at 19:32):

VolodymyrBg requested wasmtime-core-reviewers for a review on PR #10360.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 08 2025 at 19:50):

VolodymyrBg updated PR #10360.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 08 2025 at 20:10):

VolodymyrBg updated PR #10360.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 08 2025 at 20:26):

VolodymyrBg updated PR #10360.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 10 2025 at 22:29):

alexcrichton commented on PR #10360:

I think this may have lost the tests from https://github.com/bytecodealliance/wasmtime/pull/9989?

view this post on Zulip Wasmtime GitHub notifications bot (Mar 11 2025 at 16:31):

VolodymyrBg updated PR #10360.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 11 2025 at 16:31):

VolodymyrBg updated PR #10360.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 11 2025 at 16:34):

VolodymyrBg updated PR #10360.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 11 2025 at 16:35):

VolodymyrBg commented on PR #10360:

@alexcrichton corrected

view this post on Zulip Wasmtime GitHub notifications bot (Mar 11 2025 at 17:33):

alexcrichton submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 11 2025 at 17:33):

alexcrichton created PR review comment:

This unfortunately has the behavior that ff is interpreted as 255 since the trim_start_matches is an optional trim rather than a required trim. Could this be refactored to require the 0x prefix for hexadecimal arguments?

view this post on Zulip Wasmtime GitHub notifications bot (Mar 11 2025 at 18:28):

VolodymyrBg updated PR #10360.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 11 2025 at 18:29):

VolodymyrBg updated PR #10360.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 11 2025 at 18:38):

VolodymyrBg updated PR #10360.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 11 2025 at 18:38):

VolodymyrBg updated PR #10360.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 11 2025 at 18:45):

VolodymyrBg updated PR #10360.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 11 2025 at 18:49):

VolodymyrBg requested alexcrichton for a review on PR #10360.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 11 2025 at 19:21):

alexcrichton submitted PR review:

Thanks!

view this post on Zulip Wasmtime GitHub notifications bot (Mar 11 2025 at 19:58):

alexcrichton merged PR #10360.

Last updated: Apr 17 2025 at 07:03 UTC