Stream: git-wasmtime

Topic: wasmtime / PR #10352 meta: move all ISLE-related generate...

Wasmtime GitHub notifications bot (Mar 07 2025 at 03:10):

abrown requested wasmtime-compiler-reviewers for a review on PR #10352.

Wasmtime GitHub notifications bot (Mar 07 2025 at 03:10):

abrown opened PR #10352 from abrown:assembler-move-isle-generation to bytecodealliance:main:

Previously, the new cranelift-assembler-x64 crate would generate the assembler Rust code, the ISLE integration code, and the ISLE's accompanying Rust macro all in the same crate. Because these last two files were generated in the assembler's OUT_DIR, they caused issues for deterministic builds that expect those files in cranelift-codegen's OUT_DIR (see #10348). This change fixes that by moving all of the assembler's generated integration code, the ISLE instruction definitions and their accompanying Rust macro, to the cranelift-codegen-meta crate.

This has the added advantage that cranelift-assembler-x64 now can focus exclusively on being an assembler and not being concerned with the ISLE integration, which is substantial.

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Mar 07 2025 at 03:10):

abrown requested fitzgen for a review on PR #10352.

Wasmtime GitHub notifications bot (Mar 07 2025 at 03:10):

abrown requested wasmtime-default-reviewers for a review on PR #10352.

Wasmtime GitHub notifications bot (Mar 07 2025 at 04:45):

github-actions[bot] commented on PR #10352:

Subscribe to Label Action

cc @cfallin, @fitzgen

<details>
This issue or pull request has been labeled: "cranelift", "cranelift:area:x64", "cranelift:meta", "isle"

Thus the following users have been cc'd because of the following labels:

• cfallin: isle
• fitzgen: isle

To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.

Learn more.
</details>

Wasmtime GitHub notifications bot (Mar 07 2025 at 14:33):

abrown updated PR #10352.

Wasmtime GitHub notifications bot (Mar 07 2025 at 18:25):

cfallin submitted PR review:

Nice!

Wasmtime GitHub notifications bot (Mar 07 2025 at 18:25):

cfallin created PR review comment:

FWIW, we removed the invocation of rustfmt in #9901 for the main meta crate; it's an artifact of an earlier time when we had the code checked into git, but we don't now, and it can cause issues in certain build environments -- probably ok to remove it here too?

Wasmtime GitHub notifications bot (Mar 08 2025 at 00:24):

abrown updated PR #10352.

Wasmtime GitHub notifications bot (Mar 08 2025 at 00:25):

abrown has enabled auto merge for PR #10352.

Wasmtime GitHub notifications bot (Mar 08 2025 at 01:24):

abrown merged PR #10352.

Last updated: Apr 18 2025 at 08:04 UTC