Stream: git-wasmtime

Topic: wasmtime / PR #10348 meta: deduplicate source generation ...

view this post on Zulip Wasmtime GitHub notifications bot (Mar 06 2025 at 17:59):

abrown opened PR #10348 from abrown:assembler-deduplicate-srcgen to bytecodealliance:main:

When building the new cranelift-assembler-x64 crate, I duplicated some Formatter functionality that we were using in cranelift-codegen-meta to generate both Rust and ISLE code. This change splits out that functionality into a separate crate that both cranelift-assembler-x64 and cranelift-codegen-meta can depend on without depending on each other.

While doing this, I rationalized the divergence that had happened between both copies of Formatter; more details are noted in the commit messages. As a part of all of this, I will highlight that the Formatter now knows which language it is emitting (Rust or ISLE) and how to emit Rust brace-delimited blocks, a wide-ranging change.

All of this is to support the same goal as https://github.com/bytecodealliance/wasmtime/pull/10334. To avoid OUT_DIR issues, I believe we should move the ISLE generation from cranelift-assembler-x64 to cranelift-codegen-meta (with the rest of the ISLE wrangling). This PR is a first step in that direction by sorting out the crate dependencies.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 06 2025 at 17:59):

abrown requested cfallin for a review on PR #10348.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 06 2025 at 17:59):

abrown requested wasmtime-compiler-reviewers for a review on PR #10348.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 06 2025 at 17:59):

abrown requested wasmtime-default-reviewers for a review on PR #10348.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 06 2025 at 18:05):

abrown submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 06 2025 at 18:05):

abrown created PR review comment:

It felt to me that this kind of crate isn't the same as the other Cranelift crates in terms of versioning, but I suspect we will have to give it a 0.119.0 version just to get it to pass the publish.rs script? I noticed that some fuzzing infrastructure crate had a 0.0.0 version but perhaps that isn't published?

view this post on Zulip Wasmtime GitHub notifications bot (Mar 06 2025 at 18:06):

abrown submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 06 2025 at 18:06):

abrown created PR review comment:

Oh, and vets... we'll probably need vets for this.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 06 2025 at 18:09):

abrown updated PR #10348.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 06 2025 at 23:01):

cfallin submitted PR review:

This is really nice; thanks for the cleanups/refactors!

view this post on Zulip Wasmtime GitHub notifications bot (Mar 06 2025 at 23:01):

cfallin created PR review comment:

Yep, I think the version-bumping automation will fall down otherwise. Also there's this list of crates to publish that will need an update.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 07 2025 at 00:59):

abrown updated PR #10348.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 07 2025 at 01:00):

abrown has enabled auto merge for PR #10348.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 07 2025 at 02:11):

abrown updated PR #10348.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 07 2025 at 02:12):

abrown has enabled auto merge for PR #10348.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 07 2025 at 02:48):

abrown merged PR #10348.

Last updated: Apr 17 2025 at 04:04 UTC