Wasmtime GitHub notifications bot (Mar 06 2025 at 16:08): Wasmtime GitHub notifications bot (Mar 06 2025 at 16:08):bjorn3 requested abrown for a review on PR #10345.
Wasmtime GitHub notifications bot (Mar 06 2025 at 16:08):bjorn3 opened PR #10345 from bjorn3:remove_cranelift_jit_hotswap to bytecodealliance:main:
It was originally introduced for cg_clif. cg_clif recently removed it's use of hotswapping as the way it is implemented in cranelift-jit has various issues like leaking memory, panicking when the memory allocator decided to put two functions more than 2GB away from each other and only supporting x86_64. Better hotswapping support will likely require a fundamentally different implementation.
Also fix a bug that prevents cg_clif from switching to is_pic=false for the jit mode.
Wasmtime GitHub notifications bot (Mar 06 2025 at 16:08):bjorn3 requested wasmtime-compiler-reviewers for a review on PR #10345.
Wasmtime GitHub notifications bot (Mar 06 2025 at 16:13):bjorn3 commented on PR #10345:
If the second commit could be backported to the release-31.0.0 branch that would be appreciated.
Wasmtime GitHub notifications bot (Mar 06 2025 at 16:46):alexcrichton commented on PR #10345:
For the backport I think that's reasonable, would you be ok sending a PR yourself? (no need for a subset of folks to send backports to older branches, it's ok for anyone to open a PR to the branch)
Wasmtime GitHub notifications bot (Mar 06 2025 at 17:18):bjorn3 commented on PR #10345:
Opened https://github.com/bytecodealliance/wasmtime/pull/10347
Wasmtime GitHub notifications bot (Mar 06 2025 at 18:20):abrown submitted PR review:
This change seems sensible to me but I'll let @alexcrichton comment as well since he's here.
Wasmtime GitHub notifications bot (Mar 06 2025 at 18:41):alexcrichton merged PR #10345.
Last updated: Apr 17 2025 at 13:10 UTC