Stream: git-wasmtime

Topic: wasmtime / PR #10337 Winch: Fix extadd implementations

Wasmtime GitHub notifications bot (Mar 05 2025 at 20:38):

jeffcharles opened PR #10337 from jeffcharles:winch-simd-fix-extadd to bytecodealliance:main:

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Fixes #10331. The existing approach used the macroassembler v128.extend method to perform extensions but this can lead subtly incorrect results because it's designed to select values from the top half or bottom half of the vector and not from pairs of lanes within vectors. This PR changes the implementation to use machine instructions directly.

Wasmtime GitHub notifications bot (Mar 05 2025 at 20:38):

jeffcharles requested abrown for a review on PR #10337.

Wasmtime GitHub notifications bot (Mar 05 2025 at 20:38):

jeffcharles requested wasmtime-compiler-reviewers for a review on PR #10337.

Wasmtime GitHub notifications bot (Mar 05 2025 at 20:38):

jeffcharles requested fitzgen for a review on PR #10337.

Wasmtime GitHub notifications bot (Mar 05 2025 at 20:38):

jeffcharles requested wasmtime-core-reviewers for a review on PR #10337.

Wasmtime GitHub notifications bot (Mar 05 2025 at 21:45):

github-actions[bot] commented on PR #10337:

Subscribe to Label Action

cc @saulecabrera

<details>
This issue or pull request has been labeled: "winch"

Thus the following users have been cc'd because of the following labels:

• saulecabrera: winch

To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.

Learn more.
</details>

Wasmtime GitHub notifications bot (Mar 06 2025 at 00:00):

fitzgen submitted PR review:

LGTM, thanks!

Wasmtime GitHub notifications bot (Mar 06 2025 at 00:33):

saulecabrera commented on PR #10337:

You'd need to update the AVX list to get CI green:

---- Winch/./tests/misc_testsuite/winch/issue-10331.wast ----
failed to run spec test with default engine

Caused by:
    0: failed directive on ./tests/misc_testsuite/winch/issue-10331.wast:5:1
    1: failed to compile: wasm[0]::function[1]
    2: Compilation error: Instruction not implemented for CPUs without AVX support

Wasmtime GitHub notifications bot (Mar 06 2025 at 14:54):

jeffcharles updated PR #10337.

Wasmtime GitHub notifications bot (Mar 06 2025 at 15:45):

saulecabrera merged PR #10337.

Last updated: Apr 17 2025 at 01:31 UTC