Wasmtime GitHub notifications bot (Mar 01 2025 at 00:38): Wasmtime GitHub notifications bot (Mar 01 2025 at 00:38):jeffcharles opened PR #10315 from jeffcharles:winch-simd-fix-adjust-stack-results to bytecodealliance:main:
<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Fixes #10301. The existing approach didn't take the stack pointer offset into account for v128 values unlike the branches for the other Wasm types.
Wasmtime GitHub notifications bot (Mar 01 2025 at 00:38):jeffcharles requested abrown for a review on PR #10315.
Wasmtime GitHub notifications bot (Mar 01 2025 at 00:38):jeffcharles requested wasmtime-core-reviewers for a review on PR #10315.
Wasmtime GitHub notifications bot (Mar 01 2025 at 00:38):jeffcharles requested wasmtime-compiler-reviewers for a review on PR #10315.
Wasmtime GitHub notifications bot (Mar 01 2025 at 00:38):jeffcharles requested pchickey for a review on PR #10315.
Wasmtime GitHub notifications bot (Mar 01 2025 at 02:14):github-actions[bot] commented on PR #10315:
Subscribe to Label Action
cc @saulecabrera
<details>
This issue or pull request has been labeled: "winch"Thus the following users have been cc'd because of the following labels:
- saulecabrera: winch
To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.
Learn more.
</details>
Wasmtime GitHub notifications bot (Mar 03 2025 at 12:22):saulecabrera submitted PR review.
Wasmtime GitHub notifications bot (Mar 03 2025 at 12:42):saulecabrera merged PR #10315.
Last updated: Apr 18 2025 at 14:03 UTC