Wasmtime GitHub notifications bot (Feb 28 2025 at 22:41): Wasmtime GitHub notifications bot (Feb 28 2025 at 22:41):alexcrichton opened PR #10314 from alexcrichton:update-wasm-tools to bytecodealliance:main:
<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (Feb 28 2025 at 22:41):alexcrichton commented on PR #10314:
Draft for now as they're git dependencies
Wasmtime GitHub notifications bot (Mar 05 2025 at 15:35):alexcrichton updated PR #10314.
Wasmtime GitHub notifications bot (Mar 05 2025 at 16:07):alexcrichton updated PR #10314.
Wasmtime GitHub notifications bot (Mar 05 2025 at 16:07):alexcrichton requested wasmtime-core-reviewers for a review on PR #10314.
Wasmtime GitHub notifications bot (Mar 05 2025 at 16:07):alexcrichton requested pchickey for a review on PR #10314.
Wasmtime GitHub notifications bot (Mar 05 2025 at 16:07):alexcrichton requested wasmtime-default-reviewers for a review on PR #10314.
Wasmtime GitHub notifications bot (Mar 05 2025 at 16:07):alexcrichton has marked PR #10314 as ready for review.
Wasmtime GitHub notifications bot (Mar 05 2025 at 16:10):alexcrichton commented on PR #10314:
Ok this is now ready for review. It's going to have a lot of conflicts with https://github.com/bytecodealliance/wasmtime/pull/10106, however, so the plan is to land that first currently.
Wasmtime GitHub notifications bot (Mar 05 2025 at 16:51):pchickey submitted PR review.
Wasmtime GitHub notifications bot (Mar 05 2025 at 22:00):alexcrichton updated PR #10314.
Wasmtime GitHub notifications bot (Mar 05 2025 at 22:01):alexcrichton commented on PR #10314:
@dicej mind doing a once-over on this with an eye towards the component-model-async bits?
Wasmtime GitHub notifications bot (Mar 05 2025 at 22:05):alexcrichton updated PR #10314.
Wasmtime GitHub notifications bot (Mar 05 2025 at 22:14):dicej submitted PR review:
Thanks for doing this!
Wasmtime GitHub notifications bot (Mar 05 2025 at 22:14):dicej created PR review comment:
Any concerns about the cost of doing these
format!s unconditionally despite only using the result if there's an error? If so, perhaps we could make this a lambda that we call from within thewith_contextclosure.
Wasmtime GitHub notifications bot (Mar 05 2025 at 22:15):alexcrichton submitted PR review.
Wasmtime GitHub notifications bot (Mar 05 2025 at 22:15):alexcrichton created PR review comment:
Nah they were gonna all happen anyway, I just moved them a bit earlier so cranelift failures now have the function name so I don't have to go hunting down which intrinsic is the one that needs updating
Wasmtime GitHub notifications bot (Mar 05 2025 at 22:15):dicej submitted PR review.
Wasmtime GitHub notifications bot (Mar 05 2025 at 22:15):dicej created PR review comment:
Oops, nevermind, I didn't notice we use it in the non-error case. Disregard!
Wasmtime GitHub notifications bot (Mar 05 2025 at 22:18):alexcrichton updated PR #10314.
Wasmtime GitHub notifications bot (Mar 05 2025 at 22:18):alexcrichton has enabled auto merge for PR #10314.
Wasmtime GitHub notifications bot (Mar 05 2025 at 22:52):alexcrichton merged PR #10314.
Last updated: Dec 13 2025 at 20:04 UTC