Stream: git-wasmtime

Topic: wasmtime / PR #10303 Improve rebuild detection of test-pr...

Wasmtime GitHub notifications bot (Feb 27 2025 at 20:31):

alexcrichton opened PR #10303 from alexcrichton:improve-rebuild to bytecodealliance:main:

This commit improves the logic of detecting when to rebuild the test-programs artifacts used during test by parsing the *.d files that Cargo emits as part of its compilation and using that as the cargo:rerun-if-changed directive. This not only includes what was previously depended on but additionally includes features such as path dependencies which might temporarily be used during development.

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Feb 27 2025 at 20:31):

alexcrichton requested pchickey for a review on PR #10303.

Wasmtime GitHub notifications bot (Feb 27 2025 at 20:31):

alexcrichton requested wasmtime-core-reviewers for a review on PR #10303.

Wasmtime GitHub notifications bot (Feb 27 2025 at 20:31):

alexcrichton requested wasmtime-default-reviewers for a review on PR #10303.

Wasmtime GitHub notifications bot (Feb 27 2025 at 22:22):

pchickey submitted PR review:

Thanks, all good except for the gitignore

Wasmtime GitHub notifications bot (Feb 27 2025 at 22:22):

pchickey created PR review comment:

This doesn't look right

Wasmtime GitHub notifications bot (Feb 27 2025 at 22:28):

alexcrichton submitted PR review.

Wasmtime GitHub notifications bot (Feb 27 2025 at 22:28):

alexcrichton created PR review comment:

Oh this is actually intentional, although I forgot to mention it. We ./crates/test-programs/artifacts in the repo which was otherwise being ignored when new changes were being added to it and I was editing things around there so figured I'd fix it up here as well. This was added originally because our c-api documentation generated this folder in the root of the repo

Wasmtime GitHub notifications bot (Feb 27 2025 at 22:54):

alexcrichton merged PR #10303.

Last updated: Apr 18 2025 at 19:03 UTC