Wasmtime GitHub notifications bot (Feb 27 2025 at 19:25): Wasmtime GitHub notifications bot (Feb 27 2025 at 19:25):abrown requested alexcrichton for a review on PR #10302.
Wasmtime GitHub notifications bot (Feb 27 2025 at 19:25):abrown opened PR #10302 from abrown:assembler-hide-imm to bytecodealliance:main:
Previously we used
AssemblerImm*andAssemblerSimm*throughout the x64 ISLE to indicate the type of immediate an instruction would receive. Alex has noted previously that this is unnecessary; it does after all create more ties between thecranelift-codegenISLE andcranelift-assembler-x64that could possibly break in the future. This change removes those ties by using Rust types in ISLE (e.g.,u8,i8,u16, etc.) and converting to the expected assembler type in the ISLE glue layer.<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (Feb 27 2025 at 19:25):abrown requested wasmtime-compiler-reviewers for a review on PR #10302.
Wasmtime GitHub notifications bot (Feb 27 2025 at 19:25):abrown requested fitzgen for a review on PR #10302.
Wasmtime GitHub notifications bot (Feb 27 2025 at 19:30):abrown updated PR #10302.
Wasmtime GitHub notifications bot (Feb 27 2025 at 20:44):github-actions[bot] commented on PR #10302:
Subscribe to Label Action
cc @cfallin, @fitzgen
<details>
This issue or pull request has been labeled: "cranelift", "cranelift:area:x64", "isle"Thus the following users have been cc'd because of the following labels:
- cfallin: isle
- fitzgen: isle
To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.
Learn more.
</details>
Last updated: Feb 28 2025 at 01:30 UTC