Wasmtime GitHub notifications bot (Feb 26 2025 at 14:29): Wasmtime GitHub notifications bot (Feb 26 2025 at 14:29):saulecabrera opened PR #10297 from saulecabrera:winch-aarch64-effective-addr to bytecodealliance:main:
<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
This patch builds on top of https://github.com/bytecodealliance/wasmtime/pull/10263, only the last commit is relevant.
load_addrshould load the effective address, not the contents of the
address.This was causing issues with indirect function calls.
Wasmtime GitHub notifications bot (Feb 26 2025 at 14:29):saulecabrera requested wasmtime-compiler-reviewers for a review on PR #10297.
Wasmtime GitHub notifications bot (Feb 26 2025 at 14:29):saulecabrera requested cfallin for a review on PR #10297.
Wasmtime GitHub notifications bot (Feb 26 2025 at 14:29):saulecabrera requested dicej for a review on PR #10297.
Wasmtime GitHub notifications bot (Feb 26 2025 at 14:29):saulecabrera requested wasmtime-core-reviewers for a review on PR #10297.
Wasmtime GitHub notifications bot (Feb 26 2025 at 17:45):saulecabrera updated PR #10297.
Wasmtime GitHub notifications bot (Feb 26 2025 at 17:45):saulecabrera edited PR #10297:
<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
This patch builds on top of https://github.com/bytecodealliance/wasmtime/pull/10263, only the last commit is relevant.
load_addrshould load the effective address, not the contents of the
address.This was causing issues with indirect function calls.
Wasmtime GitHub notifications bot (Feb 26 2025 at 19:44):github-actions[bot] commented on PR #10297:
Subscribe to Label Action
cc @saulecabrera
<details>
This issue or pull request has been labeled: "winch"Thus the following users have been cc'd because of the following labels:
- saulecabrera: winch
To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.
Learn more.
</details>
Wasmtime GitHub notifications bot (Feb 26 2025 at 19:47):cfallin submitted PR review:
Good catch!
Wasmtime GitHub notifications bot (Feb 26 2025 at 19:47):cfallin created PR review comment:
Perhaps we could call this masm method
compute_addrto make it clearer that it's returning the address itself, not loading anything? (i.e., avoid the ambiguity where "load" could mean "load from memory" or "load a value into a register")
Wasmtime GitHub notifications bot (Feb 27 2025 at 18:44):saulecabrera updated PR #10297.
Wasmtime GitHub notifications bot (Feb 27 2025 at 18:44):saulecabrera submitted PR review.
Wasmtime GitHub notifications bot (Feb 27 2025 at 18:44):saulecabrera created PR review comment:
Good point. Renamed, thanks!
Wasmtime GitHub notifications bot (Feb 27 2025 at 18:45):saulecabrera has enabled auto merge for PR #10297.
Wasmtime GitHub notifications bot (Feb 27 2025 at 19:19):saulecabrera merged PR #10297.
Last updated: Feb 28 2025 at 03:10 UTC