Wasmtime GitHub notifications bot (Feb 21 2025 at 21:59): Wasmtime GitHub notifications bot (Feb 21 2025 at 21:59):jeffcharles requested wasmtime-compiler-reviewers for a review on PR #10271.
Wasmtime GitHub notifications bot (Feb 21 2025 at 21:59):jeffcharles requested abrown for a review on PR #10271.
Wasmtime GitHub notifications bot (Feb 21 2025 at 21:59):jeffcharles opened PR #10271 from jeffcharles:winch-simd-float-min-max to bytecodealliance:main:
<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Part of #8093. Adds support for the following instructions:
f32x4.minf64x2.minf32x4.maxf64x2.maxI explored putting the float implementations for min and max in the same helper method given how similar they are but the flow is different enough between them that I found it hard to write accurate comments and track what values were in which registers when debugging spec test failures so I've opted to just factor out the NaN canonicalization logic which is identical.
Wasmtime GitHub notifications bot (Feb 21 2025 at 21:59):jeffcharles requested dicej for a review on PR #10271.
Wasmtime GitHub notifications bot (Feb 21 2025 at 21:59):jeffcharles requested wasmtime-core-reviewers for a review on PR #10271.
Wasmtime GitHub notifications bot (Feb 21 2025 at 23:44):github-actions[bot] commented on PR #10271:
Subscribe to Label Action
cc @saulecabrera
<details>
This issue or pull request has been labeled: "winch"Thus the following users have been cc'd because of the following labels:
- saulecabrera: winch
To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.
Learn more.
</details>
Wasmtime GitHub notifications bot (Feb 24 2025 at 21:19):abrown requested saulecabrera for a review on PR #10271.
Wasmtime GitHub notifications bot (Feb 25 2025 at 11:55):saulecabrera submitted PR review:
LGTM, thanks.
Wasmtime GitHub notifications bot (Feb 25 2025 at 12:15):saulecabrera merged PR #10271.
Last updated: Feb 28 2025 at 03:10 UTC