Wasmtime GitHub notifications bot (Feb 21 2025 at 19:26): Wasmtime GitHub notifications bot (Feb 21 2025 at 19:26):abrown opened PR #10270 from abrown:backport-windows-fix to bytecodealliance:release-30.0.0:
This is a backport of #10267: The fix is necessary for Windows users who may be using absolute-path target directories: the previous solution, separating the paths by
:, runs into issues with Windows absolute paths (e.g.,C:\...). This change is similar to #10266 but should avoid any further OS compatibility issues during a hypothetical cross-compilation.<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (Feb 21 2025 at 19:26):abrown requested cfallin for a review on PR #10270.
Wasmtime GitHub notifications bot (Feb 21 2025 at 19:26):abrown requested wasmtime-compiler-reviewers for a review on PR #10270.
Wasmtime GitHub notifications bot (Feb 21 2025 at 19:31):alexcrichton submitted PR review.
Wasmtime GitHub notifications bot (Feb 21 2025 at 19:31):cfallin submitted PR review.
Wasmtime GitHub notifications bot (Feb 21 2025 at 19:31):alexcrichton commented on PR #10270:
For CI I think you'll need to backport https://github.com/bytecodealliance/wasmtime/pull/10253 too
Wasmtime GitHub notifications bot (Feb 21 2025 at 19:32):abrown commented on PR #10270:
@alexcrichton, I have a commit changing the release notes; should that go in this PR or a separate one?
Wasmtime GitHub notifications bot (Feb 21 2025 at 19:34):abrown updated PR #10270.
Wasmtime GitHub notifications bot (Feb 21 2025 at 19:34):alexcrichton commented on PR #10270:
Adding here works fine yeah
Wasmtime GitHub notifications bot (Feb 21 2025 at 19:45):abrown requested pchickey for a review on PR #10270.
Wasmtime GitHub notifications bot (Feb 21 2025 at 19:45):abrown updated PR #10270.
Wasmtime GitHub notifications bot (Feb 21 2025 at 19:45):abrown requested wasmtime-default-reviewers for a review on PR #10270.
Wasmtime GitHub notifications bot (Feb 21 2025 at 19:45):abrown updated PR #10270.
Wasmtime GitHub notifications bot (Feb 21 2025 at 19:58):alexcrichton submitted PR review.
Wasmtime GitHub notifications bot (Feb 21 2025 at 19:58):alexcrichton created PR review comment:
Oh one final thing here, can you add a bunch of
------------------between this and the 30.0.0 section below? You can copy/paste the line down below up here but the purpose is to break apart sections so we an automatically upload release notes to each github release
Wasmtime GitHub notifications bot (Feb 21 2025 at 20:01):abrown submitted PR review.
Wasmtime GitHub notifications bot (Feb 21 2025 at 20:01):abrown created PR review comment:
Sure
Wasmtime GitHub notifications bot (Feb 21 2025 at 20:02):abrown updated PR #10270.
Last updated: Feb 28 2025 at 02:27 UTC