abrown opened PR #10267 from abrown:assembler-path-macro
to bytecodealliance:main
:
This fix is necessary for Windows users who may be using absolute-path target directories: the previous solution, separating the paths by
:
, runs into issues with Windows absolute paths (e.g.,C:\...
). This change is similar to #10266 but should avoid any further OS compatibility issues during a hypothetical cross-compilation.prtest:full
<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
abrown requested cfallin for a review on PR #10267.
abrown requested wasmtime-compiler-reviewers for a review on PR #10267.
abrown updated PR #10267.
cfallin submitted PR review.
alexcrichton has enabled auto merge for PR #10267.
alexcrichton merged PR #10267.
Last updated: Feb 28 2025 at 01:30 UTC